Skip to content

chore(pmm-fb): repin both halves of the feature build - #1461

Merged
yyyyyyyan merged 2 commits into
pmmfrom
pmm-fb-repin-2c43912
Sep 4, 2026
Merged

chore(pmm-fb): repin both halves of the feature build#1461
yyyyyyyan merged 2 commits into
pmmfrom
pmm-fb-repin-2c43912

Conversation

@yyyyyyyan

@yyyyyyyan yyyyyyyan commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves both halves of sidecar/pmm-fb/compose.yaml forward together.

Service From To
pmm-serverPMM_FB_TAG, both defaults PR-4500-a2f83c2 (2026-08-25) PR-4500-2c43912 — cut 2026-09-03 from percona/pmm PMM-15205-sep-fb @ 53521917d
sep-sidecar 249f673 (2026-08-25) b97ee98 — SEP main's tip, published 2026-09-04 by Jenkins SEP/Build #235

The PMM half was two builds behind — PR-4500-d85ca73 also came and went.

What the new PMM build carries

PMM-15205-sep-fb was rebuilt as linear per-ticket history on main, and three PRs have merged into it since a2f83c2:

PR What
percona/pmm#5759 the /sep/ nginx reverse proxy, productized out of this harness's overlay
percona/pmm#5762 SEP's secret files and the generated database password
percona/pmm#5886 the vendored SEP frontend synced to SEP main c16578d

The side-car moves with it

This PR originally held sep-sidecar at 249f673, because nothing at or after c16578d had been published and there was no image to move to. That left the pair mismatched, PMM-new against SEP-old.

It no longer is. main was merged into pmm as 1efbbe8, and SEP/Build #235 published main's tip — 62 commits on from the old pin. c16578d is an ancestor of it, so the frontend sync in percona/pmm#5886 now has a side-car that answers it.

The three features that would have degraded are live instead. Each symbol is present under app/ at b97ee98 and absent at 249f673:

  • Support-case autocomplete issues requests. It is gated on case_search_available from atw_config, which this side-car sends.
  • The executor co-location warning mounts. It needs target_service on the host field's schema, which this side-car declares.
  • The unlaunchable status (SEP-1943) arrives, so its badge is exercised rather than unused.

Tested

Both pins were resolved against Docker Hub before merge: perconalab/pmm-server-fb:PR-4500-2c43912 (pushed 2026-09-03) and percona/percona-sep:b97ee985fc64f841f611b3a057737814da308a61 (pushed 2026-09-04).

The side-car image was then held against the three repin checks the harness README requires on the artifact rather than on the commit that built it:

Check Result
SECRETS_DIR references in settings-env.sh 4
Grafana token mint grafana_service_account.py present; the image's state directory is drwx------ sep sep
HEALTHCHECK, read from the raw config blob CMD runs healthcheck.sh, start period 150 s

No paired bring-up was run — this is a two-line pin change, and the artifact checks are what the README asks for at repin time.

Checklist

  • New/modified functions have type hints and rST docstrings
  • New tests added for new features or bug fixes
  • All tests pass locally (make test)
  • Pre-commit hooks pass (make run-pre-commit)
  • Database migrations generated if models changed (make makemigrations)
  • User-facing changes documented (README, inline help, UI text)
  • Configuration changes documented with examples
  • Changelog fragment added under changelog.d/ if the change is user-facing (make changelog-add), or confirmed N/A (internal-only change, or a same-release-cycle fix for an unreleased sibling ticket)

Both PMM_FB_TAG defaults move from PR-4500-a2f83c2 (2026-08-25) to
PR-4500-2c43912, cut 2026-09-03 from percona/pmm PMM-15205-sep-fb @ 53521917d.
The harness was two builds behind - PR-4500-d85ca73 also came and went.

What the new build carries that a2f83c2 did not: PMM-15205-sep-fb was rebuilt as
linear per-ticket history on main, and percona/pmm#5759 (the /sep/ nginx
reverse proxy), #5762 (SEP's secret files and generated database password) and
#5886 (the vendored SEP frontend synced to SEP main c16578d) have all merged
into it.

The side-car pin is deliberately left at 249f673. Nothing at or after
c16578d is published, so there is no image to move to - the newest tag on
percona/percona-sep is the one already pinned.

That leaves the pair mismatched, PMM-new against SEP-old, and the three newly
ported frontend features degrade rather than break:

  - Support-case autocomplete issues no requests at all. It is gated on
    case_search_available from atw_config, which this side-car does not send,
    so the field stays a plain text input.
  - The executor co-location warning never mounts: it needs target_service on
    the host field's schema, which this side-car does not declare.
  - The unlaunchable status never arrives, so its badge is simply unused.

Exercising any of those needs a side-car built at or after c16578d. The
stale-status crash fix in #5886 is not affected - stale predates all of this and
this build fixes it against any side-car.

Claude-Session: https://claude.ai/code/session_01RFUiQUpHgyaK6ozEQJ8wmT
Signed-off-by: Yan Orestes <yan.orestes@percona.com>
@yyyyyyyan
yyyyyyyan marked this pull request as ready for review September 3, 2026 23:13
@yyyyyyyan
yyyyyyyan requested a review from a team as a code owner September 3, 2026 23:13
@yyyyyyyan yyyyyyyan changed the title chore(pmm-fb): repin the feature build to PR-4500-2c43912 chore(pmm-fb): repin both halves of the feature build Sep 4, 2026
@yyyyyyyan
yyyyyyyan merged commit 8a96290 into pmm Sep 4, 2026
@yyyyyyyan
yyyyyyyan deleted the pmm-fb-repin-2c43912 branch September 4, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant